Feat/resume builder internships#117
Conversation
…rs/minutes/seconds)
|
👋 @Ericbutler1209 👋 We're delighted to have your pull request! Please take a moment to check our contributing guidelines and ensure you've filled out the PR template for a smooth process. We will review it soon. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds internship functionality to the Resume Builder application, allowing users to input and include internship experiences in their generated resumes.
- Adds internship data structure and collection functionality
- Integrates internship section into the interactive menu system
- Extends PDF generation to include formatted internship details
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Resume Builder/resume_builder.py | Adds internships data field, collection function, menu integration, and PDF generation support |
| Geographic Distance/geographic_distance.py | Adds utility functions for coordinate validation and unit conversion |
| Digital Clock/main.py | Enhances clock with 12/24-hour toggle, date display, and improved formatting |
| Age Calculator/calculate.py | Refactors code with type hints, improved naming, and enhanced output formatting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "achievements": [], | ||
| "internships":[] |
There was a problem hiding this comment.
Missing space after the colon. Should be "internships": [] to maintain consistent formatting with other dictionary entries.
| from time import strftime | ||
| from tkinter import Label, Tk | ||
| from tkinter import Label, Tk , Button |
There was a problem hiding this comment.
Extra space before comma in the import statement. Should be from tkinter import Label, Tk, Button.
|
|
||
| localtime = time.localtime(time.time()) | ||
|
|
||
| year = int(age) |
There was a problem hiding this comment.
Redundant conversion: age is already converted to int on line 21, so year = int(age) on line 25 is unnecessary. Use year = age instead.
| year = int(age) | |
| year = age |
1 participant
Added internships list to resume_data for storing entries.
Implemented add_internships() function to collect internship role, company, location, dates, and highlights.
Updated interactive menu with a new Internships option and handler.
Extended PDF generation to include an Internships section with formatted details.